This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Fix deprecation warning about promise.defer() #1292
Merged
+22
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukebarnard1
suggested changes
Aug 24, 2017
src/languageHandler.js
Outdated
| deferred.reject({err: err, response: response}); | ||
| return; | ||
| return new Promise((resolve, reject) => { | ||
| let response_return = {}; |
There was a problem hiding this comment.
Hm yeah it was already unused before. I will clean it up
|
Also, this needs sign-off |
|
Signed-Off by Marcel Radzio [email protected] |
|
Uhm why do my tests fail. Related to old develop base? |
The merge is with latest |
lukebarnard1
approved these changes
Aug 24, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
webpack3 started to complain about promise.defer() being deprecated